fix: do not fail when saving a new item using dataProvider (#3533)

vaadin · Mar 10, 2022 · 69d6441 · 69d6441
1 parent 9434057
commit 69d6441
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/packages/crud/src/vaadin-crud.js b/packages/crud/src/vaadin-crud.js
@@ -1031,6 +1031,7 @@ class Crud extends ElementMixin(ThemableMixin(PolymerElement)) {
           this.items.push(item);
         }
       } else {
+        this.editedItem = this.editedItem || {};
         Object.assign(this.editedItem, item);
       }
       this._grid.clearCache();

diff --git a/packages/crud/test/crud.test.js b/packages/crud/test/crud.test.js
@@ -137,6 +137,41 @@ describe('crud', () => {
     });
   });
 
+  describe('dataProvider', () => {
+    const items = [{ foo: 'bar' }];
+
+    beforeEach(async () => {
+      crud = fixtureSync('<vaadin-crud style="width: 300px;"></vaadin-crud>');
+      crud.dataProvider = (_, callback) => callback(items, items.length);
+      await nextRender(crud);
+      [btnSave, btnCancel, btnDelete] = crud.querySelectorAll('vaadin-button');
+    });
+
+    it('should save a new item', (done) => {
+      listenOnce(crud, 'save', (e) => {
+        expect(e.detail.item.foo).to.be.equal('baz');
+        done();
+      });
+      crud.$.new.click();
+      crud._form._fields[0].value = 'baz';
+      change(crud._form);
+      btnSave.click();
+      expect(crud.editedItem.foo).to.be.equal('baz');
+    });
+
+    it('should save an edited item', (done) => {
+      listenOnce(crud, 'save', (e) => {
+        expect(e.detail.item.foo).to.be.equal('baz');
+        done();
+      });
+      edit(items[0]);
+      crud._form._fields[0].value = 'baz';
+      change(crud._form);
+      btnSave.click();
+      expect(crud.editedItem.foo).to.be.equal('baz');
+    });
+  });
+
   ['default', 'slotted buttons'].forEach((mode) => {
     describe(`[${mode}] items`, () => {
       beforeEach(async () => {