fix: don't throw on requestContentUpdate before attaching (#2995)

vaadin · Nov 9, 2021 · 99691fc · 99691fc
1 parent bfc3fa0
commit 99691fc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/packages/select/src/vaadin-select.js b/packages/select/src/vaadin-select.js
@@ -344,6 +344,10 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
    * It is not guaranteed that the update happens immediately (synchronously) after it is requested.
    */
   requestContentUpdate() {
+    if (!this._overlayElement) {
+      return;
+    }
+
     this._overlayElement.requestContentUpdate();
 
     // Ensure menu element is set

diff --git a/packages/select/test/renderer.test.js b/packages/select/test/renderer.test.js
@@ -50,6 +50,11 @@ describe('renderer', () => {
     };
   });
 
+  it('should not throw when requesting content update before attaching to the DOM', () => {
+    const select = document.createElement('vaadin-select');
+    expect(() => select.requestContentUpdate()).not.to.throw(Error);
+  });
+
   it('should run renderers when requesting content update', () => {
     select.renderer = sinon.spy();
     select.opened = true;