Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't throw when requesting content update before attaching to DOM #2995

Merged
merged 1 commit into from
Nov 9, 2021
Merged

fix: don't throw when requesting content update before attaching to DOM #2995

merged 1 commit into from
Nov 9, 2021

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Nov 9, 2021 •
edited
Loading

Description

This PR prevents throwing an exception in the select component when requesting the content update before the component is attached to the DOM.

Extracted from #2990.

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen vursen changed the title fix: don't throw when requesting content update before attaching to the DOM fix: don't throw when requesting content update before attaching to DOM Nov 9, 2021
@vursen vursen force-pushed the fix/select/request-content-update branch from 0282865 to cb2047f Compare November 9, 2021 13:10
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen mentioned this pull request Nov 9, 2021
Merged
7 tasks
@web-padawan web-padawan merged commit 99691fc into master Nov 9, 2021
@web-padawan web-padawan deleted the fix/select/request-content-update branch November 9, 2021 13:15
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

@web-padawan web-padawan mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
prerelease version for platform 22.0.0 Released with Platform 22.0.0.beta2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vursen @vaadin-bot @web-padawan