fix: do not call renderer for disconnected columns (#7389)

vaadin · May 7, 2024 · f916e5b · f916e5b
1 parent b5a6968
commit f916e5b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/grid/src/vaadin-grid-mixin.js b/packages/grid/src/vaadin-grid-mixin.js
@@ -932,6 +932,9 @@ export const GridMixin = (superClass) =>
       this._filterDragAndDrop(row, model);
 
       iterateChildren(row, (cell) => {
+        if (cell._column && !cell._column.isConnected) {
+          return;
+        }
         if (cell._renderer) {
           const owner = cell._column || this;
           cell._renderer.call(owner, cell._content, owner, model);

diff --git a/packages/grid/test/tree-toggle.common.js b/packages/grid/test/tree-toggle.common.js
@@ -169,6 +169,13 @@ describe('tree toggle', () => {
       expect(getBodyCellContent(grid, 0, 0).firstElementChild).to.equal(toggle);
     });
 
+    it('should not throw when removing column and setting items', () => {
+      expect(() => {
+        grid.removeChild(column);
+        grid.items = [{ name: 'New name' }];
+      }).to.not.throw(Error);
+    });
+
     describe('itemHasChildrenPath', () => {
       beforeEach(() => {
         sinon.stub(console, 'warn');