Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make grid renderer arguments required #2097

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

tomivirkki
Copy link
Member

It shouldn't be possible for the grid body renderer not to have a defined model. The current typings require you to either check for the model:

private renderer: GridBodyRenderer<Person> = (root, _column, model) => {
  root.textContent = model ? model.item.lastName : '';
};

or use non-null assertion:

private renderer: GridBodyRenderer<Person> = (root, _column, model) => {
  root.textContent = model!.item.lastName;
};

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants