refactor: translate grid sticky sections with a CSS variable #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
grid-transforms-as-css-variables
branch
from
662b6bb
to
d235ab7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Aug 26, 2021
web-padawan
changed the title
|
This ticket/PR has been released with platform 22.0.0.alpha2 and is also targeting the upcoming stable 22.0.0 version. |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of the outdated logic related to translating the stationary grid sections (header/footer/frozen cells). It introduces a new private CSS variable, (
--_grid-horizontal-scroll-position), that's now used in the component styles for the necessary transforms.The new CSS variable is a prerequisite for #357