Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not set focus-ring on mousedown focus #2963

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Nov 1, 2021

Description

Added a protected getter to access keyboardActive flag handled by FocusMixin in password-field.

Fixes #2962

Type of change

  • Bugfix

@vursen
Copy link
Contributor

vursen commented Nov 1, 2021

Wait, I'm taking back my approval, should these _setFocused be also updated?

@web-padawan web-padawan marked this pull request as draft November 1, 2021 12:49
@web-padawan web-padawan marked this pull request as ready for review November 1, 2021 13:11
@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan removed the request for review from tomivirkki November 1, 2021 16:43
@web-padawan web-padawan merged commit c76f6e2 into master Nov 1, 2021
@web-padawan web-padawan deleted the fix/mouse-focus-ring branch November 1, 2021 16:43
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[password-field] Incorrectly set focus-ring when focusing using mouse
3 participants