Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use FocusMixin instead of custom logic #2970

Merged
merged 5 commits into from
Nov 3, 2021
Merged

refactor: use FocusMixin instead of custom logic #2970

merged 5 commits into from
Nov 3, 2021

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Nov 2, 2021 •
edited
Loading

Description

  1. Updated vaadin-message similarly to refactor: use FocusMixin instead of custom logic #2966
  2. Updated tests to be more aligned with vaadin-avatar and vaadin-accordion

Type of change

  • Refactor

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan requested review from tomivirkki and removed request for vursen November 3, 2021 07:31
@web-padawan web-padawan merged commit ba3a20c into master Nov 3, 2021
@web-padawan web-padawan deleted the refactor/focus-ring-message branch November 3, 2021 09:19
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
prerelease version for platform 22.0.0 Released with Platform 22.0.0.beta2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@web-padawan @vaadin-bot @tomivirkki