refactor: use new mixins, simplify keyboard handling logic #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/item-mixin
branch
from
e64a6bd
to
562fd7d
Compare
web-padawan
commented
Nov 3, 2021
| @@ -214,7 +214,6 @@ describe('edit column editor type', () => { | |||
| grid.enterNextRow = true; | |||
| const item = editor._overlayElement.querySelector('vaadin-item'); | |||
| enter(item); | |||
| item.click(); | |||
There was a problem hiding this comment.
This isn't necessary because click is called on Enter anyways.
web-padawan
force-pushed
the
refactor/item-mixin
branch
from
506f883
to
df4c012
Compare
vursen
reviewed
Nov 4, 2021
vursen
reviewed
Nov 4, 2021
vursen
reviewed
Nov 4, 2021
web-padawan
changed the title
web-padawan
force-pushed
the
refactor/item-mixin
branch
from
b1c4ed6
to
48f2066
Compare
vursen
approved these changes
Nov 5, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ActiveMixinandFocusMixinso that we handle these consistently for all components.focus-ringwhen focusing an item inside a list-boxfocus-ringwas always set unless there was amousedownevent beforefocusin,focus-ringis set only if there was akeydown(same as in button, input fields etc),focus-ringset byvaadin-select,vaadin-list-box,vaadin-menu-bar.Type of change