Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround an issue with disabled textarea freezing the browser #2981

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

tomivirkki
Copy link
Member

@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 58bad8e into master Nov 5, 2021
@web-padawan web-padawan deleted the workaround-firefox-textarea-freeze branch November 5, 2021 09:24
@vaadin-bot
Copy link
Collaborator

Hi @tomivirkki , this commit cannot be picked to 21.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 58bad8e
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 3760 and retry the command.
error: could not apply 58bad8e... fix: workaround disabled textarea freezing Firefox (#2981)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

@MBablinski
Copy link

Will it be released to Vaadin flow 14?

@tomivirkki
Copy link
Member Author

tomivirkki commented Nov 17, 2021

@MBablinski Yes, here's the PR targeted for Vaadin 14 textarea vaadin/vaadin-text-field#584

As a temporary workaround, you can add the same styles to vaadin-text-area yourself:

:host([disabled]) ::slotted(textarea) {
  user-select: none;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dragged Disabled/ReadOnly TextArea freezes Firefox tab
5 participants