Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Playwright to 1.16.3, fix grid keyboard test #3002

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

web-padawan
Copy link
Member

Description

Updated Playwright from 1.15.0 to 1.16.3 - let's see if some tests fail again and if we should fix something.

Type of change

  • Internal change

@web-padawan
Copy link
Member Author

One test is failing in WebKit, same as the previous time when I tried to upgrade Playwright:

packages/grid/test/keyboard-navigation.test.js:

 ❌ keyboard navigation > navigating with keys > horizontal scrolling > should scroll cells visible with end
      AssertionError: expected 200 to equal 400
      + expected - actual
      
      -200
      +400
      
      at r (node_modules/@esm-bundle/chai/node_modules/.pnpm/chai@4.3.4/node_modules/chai/chai.js:9576:21)
      at node_modules/@esm-bundle/chai/node_modules/.pnpm/chai@4.3.4/node_modules/chai/chai.js:251:8
      at p (node_modules/@esm-bundle/chai/node_modules/.pnpm/chai@4.3.4/node_modules/chai/chai.js:1410:10)
      at c (node_modules/@esm-bundle/chai/node_modules/.pnpm/chai@4.3.4/node_modules/chai/chai.js:7884:30)
      at handleDom (node_modules/@open-wc/semantic-dom-diff/chai-dom-diff.js:102:21)
      at f (node_modules/@esm-bundle/chai/node_modules/.pnpm/chai@4.3.4/node_modules/chai/chai.js:9164:38)
      at packages/grid/test/keyboard-navigation.test.js:1031:49

@web-padawan web-padawan changed the title chore: upgrade Playwright version to 1.16.3 chore: update Playwright to 1.16.3, fix grid keyboard test Nov 10, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants