Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show checkmark for checked menu item #3004

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

web-padawan
Copy link
Member

Description

Fixes #2985 which was introduced by #2879 (adding checkmark part). Also added a visual test.

Type of change

  • Bugfix

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
Copy link
Contributor

Can confirm that context menu has been fixed. However it seems the same issue also applies to menu bar, see this example for reference: https://vaadin.com/docs/latest/ds/components/menu-bar/#checkable-menu-items

@web-padawan
Copy link
Member Author

@sissbruecker Note that vaadin-menu-bar uses the vaadin-context-menu-item internally:

if (isElement && itemComponent.localName === 'vaadin-context-menu-item') {
component = itemComponent;
} else {
component = document.createElement('vaadin-context-menu-item');
component.appendChild(isElement ? itemComponent : document.createElement(itemComponent));
}

@web-padawan web-padawan merged commit 1d8dede into master Nov 10, 2021
@web-padawan web-padawan deleted the fix/menu-item-checked branch November 10, 2021 13:44
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vaadin-context-menu checked state broken in v22
3 participants