Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simplify themable-mixin imports in tests #3012

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

web-padawan
Copy link
Member

Description

Since #2594 register-styles.js is just a re-export so we can use the themable-mixin.js import instead.
Same as #3009 but for test folders, therefore the commit is test: and not refactor:

Type of change

  • Refactor

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit be3def7 into master Nov 10, 2021
@web-padawan web-padawan deleted the test/themable-imports-test branch November 10, 2021 14:03
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants