fix: use click event for opening sub-menus on touch devices #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
fix-sub-menu-touch
branch
from
44921c0
to
627e5d5
Compare
web-padawan
reviewed
Jan 21, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Jan 24, 2022
|
This ticket/PR has been released with platform 23.0.0.alpha4 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3300
The problem with the current implementation is that the sub-menus are opened with a "mouseover" event also on touch devices. The "mouseover" event is followed by a click that then closes the sub-menu immediately.
This PR changes context-menu to use "click" events for opening sub-menus on touch devices. On non-touch devices, the behavior stays as it is.