fix: don't update items manually on selection change #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
commented
Jan 25, 2022
Comment on lines
-81
to
-85
| if (this.$.items.children.length && (e.path === 'selectedItems' || e.path === 'selectedItems.splices')) { | ||
| Array.from(this.$.items.children).forEach((row) => { | ||
| this._updateItem(row, row._item); | ||
| }); | ||
| } |
There was a problem hiding this comment.
The current selected items change observer calls _updateItem function manually for all body row elements, even if they're in loading state, or completely out of use / hidden.
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Jan 25, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
web-padawan
pushed a commit
that referenced
this pull request
Jan 25, 2022
|
This ticket/PR has been released with platform 23.0.0.alpha4 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/flow-components#2552
Fixes #2247
Fixes vaadin/flow-components#1913