-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[date-picker] fix: prevent input blur on calendar icon click #3398
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that there is no more blur
event on toggle button click 👍
Hi @DiegoCardoso , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually? |
Could this be tested with |
Yes, we could indeed try using |
I tried to use |
This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version. |
Description
As described on this issue, when the user clicks on the calendar icon when the
DatePicker
(or, in the case reported by the issue, aDateTimePicker
) is inside aGridPro
, the editor gets closed. The same do not happen when the clock icon on the TimePicker is clicked.The issue comes to the fact that when the user clicks on the calendar icon, the input field is briefly blurred, which causes a
blur
event that is listened by theGridPro
and it stops the edit mode of the cell.This change applies the same code that is used on ComboBox to prevent the blur event from being fired when the user clicks on the toggle button.
Part of vaadin/flow-components#2428
Type of change