Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not open dropdown on helper click #3402

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

web-padawan
Copy link
Member

Description

Updated host event listener to check if the click was on the label or input field.

Fixes #3399

Type of change

  • Bugfix

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 67b8a7c into master Feb 7, 2022
@web-padawan web-padawan deleted the fix/combo-box-helper-click branch February 7, 2022 11:18
web-padawan added a commit that referenced this pull request Feb 7, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[combo-box] Field should not be focused on helper click
3 participants