Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make map accessible through keyboard #3403

Merged
merged 6 commits into from
Feb 10, 2022

Conversation

sissbruecker
Copy link
Contributor

@sissbruecker sissbruecker commented Feb 7, 2022

Description

Enables keyboard accessibility features in the OpenLayers map, and adds focus ring. Also changes the default interactions to allow mouse-wheel zoom and drag-pan while the map is not focused. This behaviour should be configurable at some point, but for now we can use this as sefault

Fixes vaadin/flow-components#2515

@sissbruecker sissbruecker force-pushed the feat/map_keyboard_accessibility branch from 24cab7d to 23c1812 Compare February 9, 2022 13:50
@sissbruecker sissbruecker marked this pull request as ready for review February 9, 2022 13:51
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small comments.

packages/map/src/vaadin-map.js Show resolved Hide resolved
packages/map/src/vaadin-map.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit b541f43 into master Feb 10, 2022
@web-padawan web-padawan deleted the feat/map_keyboard_accessibility branch February 10, 2022 09:39
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[map] Accessibility
3 participants