fix: forward tabindex attribute to focusElement #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/forward-tabindex
branch
2 times, most recently
from
e49e92f
to
9266dde
Compare
web-padawan
force-pushed
the
fix/forward-tabindex
branch
from
a75e118
to
7206f91
Compare
tomivirkki
approved these changes
Feb 10, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
web-padawan
added a commit
that referenced
this pull request
Feb 11, 2022
|
This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-introduced logic to forward
tabindexattribute toDelegateFocusMixinfor handlingtabindex="-1"on the host.This PR also changes how
tabindexproperty is defined:TabindexMixinwe set default value to0for components withoutfocusElementsuch asvaadin-buttonDelegateFocusMixinwe reset value toundefinedbecause we don't want host element to be focusableShadowFocusMixinwe have to set value back to0to forward into shadow DOM forvaadin-detailsFixes vaadin/flow-components#2455
Type of change