fix: do not set aria-expanded on grid cells #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
approved these changes
Feb 15, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
web-padawan
added a commit
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
aria-expandedis used byvaadin-gridweb component in two cases:aria-expandedset on<tr>(which is correct)aria-expandedset on<td>(does not look correct).The reason for this is that row details feature was implemented before Tree Grid.
As discussed, let's remove
aria-expandedfrom individual cells for now.We can consider using
aria-detailswhen it has better support.Fixes #3425
Type of change