fix: stop propagation for grid Tab keydown #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
knoobie
reviewed
Feb 22, 2022
tomivirkki
approved these changes
Feb 22, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
web-padawan
added a commit
that referenced
this pull request
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like the focus trap logic in
vaadin-overlaymesses up grid keyboard navigation.This can be especially observed when moving focus to an element outside the grid.
Suggested fix is to call
stopPropagation()forkeydownevent with Tab key.Fixes vaadin/flow-components#1228
Type of change