fix: avoid overriding custom button content and theme #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
approved these changes
Feb 24, 2022
|
Going to improve the JSdoc a bit to clarify the behavior. |
Done |
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Feb 24, 2022
|
This ticket/PR has been released with platform 23.0.0.rc1 and is also targeting the upcoming stable 23.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes confirm dialog to not apply the text and theme values when using custom buttons. Custom buttons should not be altered, especially the content, which might contain custom elements like icons.
This might break stuff for developers that have adapted to the broken behavior, and set text and theme in addition to adding a custom button. Seeing that we did not get a bug report about this behavior so far, it might not be a very common use-case.
Fixes vaadin/flow-components#2709
Type of change