fix: use margin for centered theme variant #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/lumo-centered-scroll
branch
from
c05080b
to
3bedcbb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jouni
approved these changes
Mar 8, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
web-padawan
added a commit
that referenced
this pull request
Mar 8, 2022
|
This ticket/PR has been released with Vaadin 23.0.2. |
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
justify-content: centerhas a drawback of making first tab inaccessible when there is a horizontal overflow.Updated to use
margin-left: autoandmargin-right: autoinstead to avoid this problem.Fixes #3418
Type of change