Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if item exists before accessing it #3513

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Mar 3, 2022

Description

I wasn't able to reproduce the original issue, so it's unclear how this can be tested.

Fixes vaadin/flow-components#1885

Type of change

  • Bugfix

@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@tomivirkki tomivirkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tried the original test app and couldn't reproduce the issue.

@web-padawan web-padawan merged commit 001492c into master Mar 3, 2022
@web-padawan web-padawan deleted the fix/avatar-group-check branch March 3, 2022 13:37
web-padawan added a commit that referenced this pull request Mar 3, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AvatarGroup throws "(TypeError): item is undefined" when adding a second avatar
3 participants