Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cleanup obsolete frozen column test #3569

Merged
merged 1 commit into from
Mar 16, 2022
Merged

test: cleanup obsolete frozen column test #3569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 1 addition & 10 deletions packages/grid/test/frozen-columns.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { expect } from '@esm-bundle/chai';
import { fixtureSync, listenOnce } from '@vaadin/testing-helpers';
import '@vaadin/polymer-legacy-adapter/template-renderer.js';
import '../vaadin-grid.js';
import { flushGrid, getRowCells, getRows, infiniteDataProvider, isWithinParentConstraints, wheel } from './helpers.js';
import { flushGrid, getRowCells, getRows, infiniteDataProvider, isWithinParentConstraints } from './helpers.js';

// Returns true if the element's computed transform style matches with the
// computed transform style of a div element with the given transform applied
Expand Down Expand Up @@ -48,15 +48,6 @@ const transformsEqual = (element, transform) => {

after(() => document.documentElement.removeAttribute('dir'));

!isRTL &&
it('should not throw on scrolling when dir changed to rtl after frozen columns set', () => {
columns[0].frozen = true;
grid._debouncerCacheElements.flush();
grid.setAttribute('dir', 'rtl');
// Emulate scrolling with the wheel
expect(() => wheel(grid, 1, 1)).not.to.throw(Error);
});

it('should have last frozen only when there are frozen columns', () => {
expect(columns[0]._lastFrozen).to.be.true;

Expand Down