fix: do not dispatch cell-focus on mouse up outside of cell #3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
commented
Mar 21, 2022
| @@ -685,13 +685,16 @@ class Grid extends ElementMixin( | |||
| // focusable slot wrapper, that is why cells are not focused with | |||
| // mousedown. Workaround: listen for mousedown and focus manually. | |||
| cellContent.addEventListener('mousedown', () => { | |||
| if (window.chrome) { | |||
| if (isChrome) { | |||
There was a problem hiding this comment.
The previous check did not work properly in tests with headless Chrome.
vursen
reviewed
Mar 22, 2022
vursen
reviewed
Mar 23, 2022
vursen
approved these changes
Mar 23, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
* fix: do not dispatch cell-focus on mouse up outside of cell * import chrome check from test helpers * address review comments * add test for clicking on cell content child * refactor to skip whole suite
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
* fix: do not dispatch cell-focus on mouse up outside of cell * import chrome check from test helpers * address review comments * add test for clicking on cell content child * refactor to skip whole suite
sissbruecker
added a commit
that referenced
this pull request
Mar 23, 2022
…3593) * fix: do not dispatch cell-focus on mouse up outside of cell * import chrome check from test helpers * address review comments * add test for clicking on cell content child * refactor to skip whole suite Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker
added a commit
that referenced
this pull request
Mar 23, 2022
…3594) * fix: do not dispatch cell-focus on mouse up outside of cell * import chrome check from test helpers * address review comments * add test for clicking on cell content child * refactor to skip whole suite Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a workaround in Chrome for the cell-focus event, where a mouse up event outside of the grid could trigger a cell focus event from a cell. The fix involves checking if the mouse up event occured on the same cell as the mouse down event.
Fixes vaadin/flow-components#2863
Type of change