fix: improve resizing column min width logic #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouni
reviewed
Mar 22, 2022
tomivirkki
reviewed
Mar 22, 2022
web-padawan
force-pushed
the
fix/resize-column-min-width
branch
from
c9a706b
to
654ea30
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Mar 23, 2022
DiegoCardoso
approved these changes
Mar 23, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 23, 2022
web-padawan
added a commit
that referenced
this pull request
Mar 24, 2022
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3588
vaadin-grid-cell-content10with the actual resize handle widthResult
Normal column minimum width after resize (the resize handle uses
35px).Last column minimum width after resize (the resize handle uses
18px).We could probably hardcode
35for performance and consistency 🙈Type of change