refactor: use inline style for cell transform #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
fix-frozen-transform-performance
branch
from
98f2d55
to
c0136a7
Compare
tomivirkki
force-pushed
the
fix-frozen-transform-performance
branch
from
7c3cae4
to
55b55cc
Compare
tomivirkki
commented
Mar 25, 2022
| @@ -1063,6 +1063,13 @@ describe('keyboard navigation', () => { | |||
|
|
|||
| flushGrid(grid); | |||
|
|
|||
| // Force reflow to workaround a Safari rendering issue | |||
There was a problem hiding this comment.
Needed to workaround a Safari rendering issue in the test case. Seems that the test renders funny on master also (even though it oddly passes):
Kapture.2022-03-25.at.13.27.39.mp4
web-padawan
changed the title
tomivirkki
force-pushed
the
fix-frozen-transform-performance
branch
from
1a2f89a
to
5eb479c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/flow-components#2930