-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dialog title, header and footer renderers #3623
Conversation
Co-authored-by: Jouni Koivuviita <jouni@vaadin.com>
The PR is almost ready. Missing:
|
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIxed review suggestions. I will check again if there's any left.
Kudos, SonarCloud Quality Gate passed!
|
_headerTitleRenderer() { | ||
if (this.headerTitle) { | ||
if (!this.headerTitleElement) { | ||
this.headerTitleElement = document.createElement('span'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was checking some component libraries and the ones I found use <h2>
for the dialog title. Should we use it here, as well? @jouni @web-padawan
Examples:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a similar issue for vaadin-confirm-dialog
header level (currently hardcoded to <h3>
) and here is a comment that suggests not to hardcode it but let the developer choose: #467 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create a follow-up issue and discuss this separately to not block this PR.
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
Description
Adds new features to dialog:
headerRenderer
andfooterRenderer
)Fixes #1513
Type of change
Additional for
Feature
type of change