test: disable buttons animation in visual tests #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
changed the title
vursen
changed the title
web-padawan
approved these changes
Apr 19, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 19, 2022
vursen
added a commit
that referenced
this pull request
Apr 19, 2022
vursen
added a commit
that referenced
this pull request
Apr 19, 2022
|
This ticket/PR has been released with Vaadin 23.1.0.alpha3 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turned out that there was a box-shadow animation of menu-bar buttons in the Material theme that wasn't disabled in visual tests which resulted in their instability. The PR disables that animation.
Note, during the animation, the browser may allocate the involved elements to separate layers for optimization purposes, which in turn may affect the font rendering making the test flaky.
Part of #3538
Type of change
Checklist