Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: speed up the keyboard tests #3798

Merged
merged 1 commit into from
May 6, 2022
Merged

test: speed up the keyboard tests #3798

merged 1 commit into from
May 6, 2022

Conversation

vursen
Copy link
Contributor

@vursen vursen commented May 6, 2022 •
edited
Loading

Description

This PR sets the scroll duration to 0 for the date-picker keyboard tests to speed them up.

Here are the results I got on my M1 machine:

Before:

yarn run v1.22.18
$ web-test-runner --group date-picker

Finished running tests in 14.2s, all tests passed! 🎉

✨  Done in 14.67s.

After:

yarn run v1.22.18
$ web-test-runner --group date-picker

Finished running tests in 4.9s, all tests passed! 🎉

✨  Done in 5.28s.

Type of change

  • Internal

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

vursen
vursen commented May 6, 2022
View reviewed changes
packages/date-picker/src/vaadin-date-picker-overlay-content.js
@@ -233,6 +233,11 @@ class DatePickerOverlayContent extends ControllerMixin(ThemableMixin(DirMixin(Po

static get properties() {
return {
scrollDuration: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an internal component, so I thought it doesn't matter whether the property should start with _ or not.

@vursen vursen requested a review from web-padawan May 6, 2022 12:37
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit 003c16e into master May 6, 2022
@web-padawan web-padawan deleted the test/speed-up-date-picker-tests branch May 6, 2022 12:45
vaadin-bot pushed a commit that referenced this pull request May 6, 2022
@vursen @vaadin-bot
test: speed up the keyboard tests (#3798)
63e29f7
vursen added a commit that referenced this pull request May 6, 2022
@vaadin-bot @vursen @web-padawan
test: speed up the keyboard tests (#3798) (CP: 23.0) (#3799)
2d6e42b 
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@web-padawan web-padawan mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.0 target/23.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vursen @tomivirkki @web-padawan @vaadin-bot