fix!: set correct role attribute on the list-box and item #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Jan 26, 2023
web-padawan
force-pushed
the
refactor/list-box-role
branch
from
9eb956e
to
3464849
Compare
vursen
reviewed
Jan 26, 2023
vursen
approved these changes
Jan 26, 2023
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
|
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #154
Fixes #5378
roleattribute forvaadin-list-boxelement fromlisttolistbox;vaadin-itemto setrole="option"instead of expecting the list-box to set it;aria-multiselectableattribute toMultiSelectListMixin;vaadin-avatar-groupandvaadin-selectthat use list-box and item accordingly;vaadin-selectto removeroleattribute andaria-selectedfrom the cloned item;Type of change
Screen readers
VoiceOver + Chrome
Before (broken)
After (working)
Two announcements: "not selected" for the item and "selected" for the list-box:
NVDA + Edge
New behavior (after) - didn't check the old one:
JAWS + Edge
Nnew behavior (after) - didn't check the old one: