fix: set aria-selected on selected item, not the focused one #5402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
approved these changes
Jan 26, 2023
| * @protected | ||
| * @override | ||
| */ | ||
| _isItemSelected(item, _selectedItem, itemIdPath) { |
There was a problem hiding this comment.
On multi-select-combo-box, for some reason, VO always reads not-selected, selected for not selected items and selected, selected for selected items. This can be handled separately from this PR:
There was a problem hiding this comment.
Yeah, it seems to be a separate issue since it also happens on master. Also, ed31808 doesn't seem to have any effect on multi-select-combo-box.
vursen
approved these changes
Jan 26, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
web-padawan
added a commit
that referenced
this pull request
Jan 26, 2023
|
This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #720
This PR fixes an issue found by @vursen while looking into the
vaadin-list-boxfix foraria-selectedstate.For some historical reasons, we originally tried to announce focused item change by updating this attribute.
At least in VoiceOver this causes duplicate announcements: both the input text and item are announced.
Now when the
<input>element is placed in light DOM and linked with the overlay, let's fix this logic.Type of change
Testing
VoiceOver + Chrome
Both selected and not selected states are announced 🎉
Note, VoiceOver + Safari has known issues that don't seem to be affected by this PR: #2748
JAWS + Edge
Selected item is not announced. This problem also exists on master, I think it's because of focus not moving to the item.
This seems to be the same as #163 - we can't really do anything about it, without changing how combo-box works 😕
NVDA + Edge
Selected item is not announced, instead items that are not selected get announced. So it seems to work as expected 😎