Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add required vertical space for combo-box overlay #5432

Merged
merged 9 commits into from
Feb 2, 2023
Merged

fix: add required vertical space for combo-box overlay #5432

merged 9 commits into from
Feb 2, 2023

Commits on Feb 1, 2023

  1. fix: add required vertical space for combo-box overlay

    @tomivirkki
    tomivirkki committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    f4d05d8 View commit details
    Browse the repository at this point in the history

  2. test: cleanup

    @tomivirkki
    tomivirkki committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2bc7481 View commit details
    Browse the repository at this point in the history

  3. test: fix the tests to use a lazy data provider

    @tomivirkki
    tomivirkki committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    b372cba View commit details
    Browse the repository at this point in the history

  4. fix: ignore calculated overlay height if the prop is used

    @tomivirkki
    tomivirkki committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    8d53297 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. docs: update property description.

    @tomivirkki
    tomivirkki committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    b9b1d1f View commit details
    Browse the repository at this point in the history

  2. Update packages/combo-box/test/overlay-position.test.js 

    Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
    @tomivirkki @web-padawan
    tomivirkki and web-padawan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    bf65794 View commit details
    Browse the repository at this point in the history

  3. Update packages/combo-box/test/overlay-position.test.js 

    Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
    @tomivirkki @web-padawan
    tomivirkki and web-padawan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    529a183 View commit details
    Browse the repository at this point in the history

  4. Update packages/overlay/src/vaadin-overlay-position-mixin.js 

    Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
    @tomivirkki @web-padawan
    tomivirkki and web-padawan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0a0c8f7 View commit details
    Browse the repository at this point in the history

  5. Update packages/overlay/src/vaadin-overlay-position-mixin.d.ts 

    Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
    @tomivirkki @web-padawan
    tomivirkki and web-padawan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    35c1b6d View commit details
    Browse the repository at this point in the history