fix: inflate functions in arrays #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Mar 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
approved these changes
Mar 10, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* fix: inflate functions in arrays * refactor: handle arrays in separate blocks for clarification
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* fix: inflate functions in arrays * refactor: handle arrays in separate blocks for clarification
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
* fix: inflate functions in arrays * refactor: handle arrays in separate blocks for clarification
vursen
pushed a commit
that referenced
this pull request
Mar 10, 2023
vursen
pushed a commit
that referenced
this pull request
Mar 10, 2023
vursen
pushed a commit
that referenced
this pull request
Mar 10, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
inflateFunctionsfunction currently does not handle functions in arrays, which causes the export buttons to break.This is a regression introduced by a previous fix. This PR updates the logic so that the objects inside arrays are also fed into the function again.
Fixes #4696
Type of change
Checklist