Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make extension patterns match the end of the file name (#5652) (CP: 23.3) #5661

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: make extension patterns match the end of the file name (#5652) (CP: 23.3) #5661

merged 1 commit into from
Mar 13, 2023

Conversation

ugur-vaadin
Copy link
Contributor

Description

Cherry-pick of 5652 to v23.3.

Fixes #4777

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ugur-vaadin ugur-vaadin merged commit 9015a1f into 23.3 Mar 13, 2023
@ugur-vaadin ugur-vaadin deleted the 4777-cannot-add-a-file-for-an-upload-cherry-pick-23-3 branch March 13, 2023 11:17
@ugur-vaadin ugur-vaadin removed the request for review from bwajtr March 13, 2023 11:17
vaadin-bot pushed a commit that referenced this pull request Mar 13, 2023
@ugur-vaadin @vaadin-bot
fix: cherry-pick from 5652 to v23.3 (#5661)
c762e62
ugur-vaadin added a commit that referenced this pull request Mar 14, 2023
@vaadin-bot @ugur-vaadin
fix: cherry-pick from 5652 to v23.3 (#5661) (#5663)
4c37764 
Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vursen vursen vursen approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.2 target/23.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ugur-vaadin @vursen @vaadin-bot