Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-initialize Quill on detach and re-attach and keep htmlValue #6506

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Sep 18, 2023

Description

Fixes #6480

Same as #6489 but with a fix to flush the value debouncer in disconnectedCallback().

Type of change

  • Bugfix

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan removed the request for review from tomivirkki September 19, 2023 12:01
@web-padawan web-padawan merged commit aa5388e into main Sep 19, 2023
9 checks passed
@web-padawan web-padawan deleted the fix/quill-listeners-reattach branch September 19, 2023 12:04
vaadin-bot pushed a commit that referenced this pull request Sep 19, 2023
…6506)

Co-authored-by: sujoykd <106066145+sujoykd@users.noreply.github.com>
vaadin-bot pushed a commit that referenced this pull request Sep 19, 2023
…6506)

Co-authored-by: sujoykd <106066145+sujoykd@users.noreply.github.com>
web-padawan added a commit that referenced this pull request Sep 19, 2023
…6506) (#6514)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: sujoykd <106066145+sujoykd@users.noreply.github.com>
web-padawan added a commit that referenced this pull request Sep 19, 2023
…6506) (#6513)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: sujoykd <106066145+sujoykd@users.noreply.github.com>
ghost pushed a commit to dethell/web-components that referenced this pull request Sep 26, 2023
…aadin#6506)

Co-authored-by: sujoykd <106066145+sujoykd@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.beta1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vaadin-rich-text-editor does not clean up all event listeners
4 participants