docs: add label property JSDoc annotation to vaadin-item #6919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Dec 7, 2023
web-padawan
force-pushed
the
docs/item-label-property
branch
from
c28fa8d
to
10c8d96
Compare
|
SonarCloud Quality Gate failed.
|
tomivirkki
approved these changes
Dec 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
web-padawan
added a commit
that referenced
this pull request
Dec 7, 2023
web-padawan
added a commit
that referenced
this pull request
Dec 7, 2023
… 23.3) (#6923) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
added a commit
that referenced
this pull request
Dec 7, 2023
web-padawan
added a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/react-components#147
We are using the
labelattribute invaadin-selectto get the item label, but it's currently not documented:web-components/packages/select/src/vaadin-select-base-mixin.js
Line 408 in 25bb261
This change adds the
labelproperty tovaadin-itemAPI docs (and alsoweb-types.json):Type of change