Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing export for DetailsSummary component class #6929

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: add missing export for DetailsSummary component class #6929

merged 1 commit into from
Dec 7, 2023

Conversation

web-padawan
Copy link
Member

Description

We missed to add export for the JS class in vaadin-details-summary which breaks the React wrapper:

Uncaught SyntaxError: The requested module '/@fs/Users/serhii/vaadin/react-components/node_modules/.vite/deps/@vaadin_details_vaadin-details-summary__js.js?v=9c5ddbf1' does not provide an export named 'DetailsSummary' (at DetailsSummary.ts:2:10)

Type of change

  • Bugfix

@web-padawan web-padawan mentioned this pull request Dec 7, 2023
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan mentioned this pull request Dec 7, 2023
Merged
@web-padawan web-padawan merged commit 8254fcd into main Dec 7, 2023
9 checks passed
@web-padawan web-padawan deleted the fix/details-summary-export branch December 7, 2023 13:02
vaadin-bot pushed a commit that referenced this pull request Dec 7, 2023
@web-padawan @vaadin-bot
fix: add missing export for DetailsSummary component class (#6929)
f13df66
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.1, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 8254fcd
error: could not apply 8254fcd... fix: add missing export for DetailsSummary component class (#6929)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Dec 7, 2023
@vaadin-bot @web-padawan
fix: add missing export for DetailsSummary component class (#6929) (#…
3f7c761 
…6932)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Dec 7, 2023
@web-padawan
fix: add missing export for DetailsSummary component class (#6929)
7272d49
@web-padawan web-padawan mentioned this pull request Dec 7, 2023
Merged
web-padawan added a commit that referenced this pull request Dec 7, 2023
@web-padawan
fix: add missing export for DetailsSummary component class (#6929) (#…
9f593f2 
…6933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.2 need to pick manually 24.1 target/24.1 target/24.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@web-padawan @vaadin-bot @tomivirkki