feat: add script to build type definitions for theme folders #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Jan 15, 2024
web-padawan
force-pushed
the
feat/theme-folders-typings
branch
from
b60a382
to
e71de2c
Compare
tomivirkki
approved these changes
Jan 15, 2024
web-padawan
force-pushed
the
feat/theme-folders-typings
branch
from
e71de2c
to
1074846
Compare
|
sissbruecker
approved these changes
Jan 15, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha2 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7073
Added a script that does the following:
.jsfiles in theme folders to.tstscto generates.d.tsfiles for them.jsfiles back and removes.tsAlso added
.d.tsfiles to.gitignoreso we don't commit them.Type of change