fix: improve readonly invalid input container styles #7204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knoobie
reviewed
Mar 13, 2024
| @@ -35,6 +35,12 @@ describe('input-container', () => { | |||
| await visualDiff(div, 'invalid'); | |||
| }); | |||
|
|
|||
| it('readonly invalid', async () => { | |||
| element.readonly = true; | |||
| element.invalid = true; | |||
There was a problem hiding this comment.
Thanks for the fix 👍 would it make sense to add text in the field to ensure that it's readable?
There was a problem hiding this comment.
Yes, probably. We don't have visual tests for regular readonly with value. Created an issue: #7207
sissbruecker
approved these changes
Mar 13, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
web-padawan
added a commit
that referenced
this pull request
Mar 14, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha15 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1196 by applying workaround from #1196 (comment).
Note: when removing
readonlythere is a short flash. This is a separate issue not specific to invalid state.Type of change