-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fire change event on hyperlink edit, update test timings #7250
Conversation
Quality Gate passedIssues Measures |
Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 23.4, i have encountered the following issue. Can you take a look and pick it manually? |
This ticket/PR has been released with Vaadin 24.4.0.alpha17 and is also targeting the upcoming stable 24.4.0 version. |
Description
Fixes #7249
When adding link, the
change
event was not fired byvaadin-rich-text-editor
. Here's what happened:this._editor.format('link', link, SOURCE.USER)
,focus
event listener calls_cleanToolbarState()
immediately,value
change observer, no change event due to the toolbar in "default" state.Added a check for
_linkEditing
(which corresponds to the link dialogopened
property) as a fix.Note: when removing the
focus
listener completely, all the tests still pass onmain
branch 🙈Type of change