fix: set display none on overlay part to fix Safari 17.4 issue (#7246) (CP: 23.4) #7256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
Mar 21, 2024
web-padawan
force-pushed
the
cp/overlay-safari-23.4
branch
11 times, most recently
from
5fcaa5f
to
484d96f
Compare
web-padawan
force-pushed
the
cp/overlay-safari-23.4
branch
from
484d96f
to
eaeb678
Compare
|
This date-time-picker test seems flaky (passes in Chrome but fails in Firefox / WebKit). I'm going to skip it for now |
|
|
This ticket/PR has been released with Vaadin 23.5.0.alpha1 and is also targeting the upcoming stable 23.5.0 version. |
|
This ticket/PR has been released with Vaadin 23.4.1. |
This was referenced Jun 10, 2024
[Snyk] Upgrade @vaadin/vaadin-lumo-styles from 23.4.0 to 23.5.1
vaadin/skeleton-starter-flow-cdi#663
Closed
Closed
Closed
This was referenced Jun 11, 2024
Closed
This was referenced Jun 12, 2024
[Snyk] Upgrade @vaadin/vaadin-lumo-styles from 23.4.0 to 23.5.1
vaadin/skeleton-starter-flow-cdi#665
Closed
Closed
This was referenced Jun 12, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual cherry-pick of #7246 to
23.4branch with focus-trap tests updated accordingly.Type of change