fix: close select overlay when clicking already selected item #7288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/select-close-on-click
branch
from
6a6d609
to
4d09a75
Compare
|
vursen
approved these changes
Mar 28, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
web-padawan
added a commit
that referenced
this pull request
Mar 28, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha20 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7286
The PR where the change was introduced contains some clarification: https://github.com/vaadin/web-components/pull/6256/files#r1276178338
However, it turns out that removal of
this.opened = falsewas problematic as it resulted in the regression.Type of change