Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow editing patch file name #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow editing patch file name #2

wants to merge 1 commit into from

Conversation

mrudat
Copy link

@mrudat mrudat commented Nov 27, 2019

No description provided.

vabatta
vabatta requested changes Jan 25, 2020
View reviewed changes
Copy link
Owner

@vabatta vabatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added the name as an option, but I don't see it begin used in the code. The patch file name would still be the hard coded one.

@mrudat
Copy link
Author

mrudat commented May 18, 2020

All that is required is to add the setting to the settings page, which will allow the user to edit the target patch file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vabatta vabatta vabatta requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrudat @vabatta