Update United Kingdom holidays: fix observed New Year's Day in Scotla…

…nd (#1735)
vacanza · Mar 19, 2024 · e236b40 · e236b40
1 parent 28f629e
commit e236b40
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 31 deletions.
diff --git a/holidays/countries/united_kingdom.py b/holidays/countries/united_kingdom.py
@@ -154,13 +154,14 @@ def _populate_subdiv_nir_public_holidays(self):
 
     def _populate_subdiv_sct_public_holidays(self):
         # New Year's Day
-        self._add_observed(self._add_new_years_day("New Year's Day"))
+        jan_1 = self._add_new_years_day("New Year's Day")
 
         # New Year Holiday
         self._add_observed(
             self._add_new_years_day_two("New Year Holiday"),
             rule=SAT_SUN_TO_NEXT_MON_TUE + MON_TO_NEXT_TUE,
         )
+        self._add_observed(jan_1)
 
         # Summer bank holiday (first Monday in August)
         self._add_holiday_1st_mon_of_aug("Summer Bank Holiday")

diff --git a/snapshots/countries/GB_SCT.json b/snapshots/countries/GB_SCT.json
@@ -1,7 +1,7 @@
 {
     "1950-01-01": "New Year's Day",
     "1950-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1950-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1950-01-03": "New Year Holiday (observed)",
     "1950-04-07": "Good Friday",
     "1950-08-07": "Summer Bank Holiday",
     "1950-12-25": "Christmas Day",
@@ -37,7 +37,7 @@
     "1955-12-26": "Christmas Day (observed)",
     "1956-01-01": "New Year's Day",
     "1956-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1956-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1956-01-03": "New Year Holiday (observed)",
     "1956-03-30": "Good Friday",
     "1956-08-06": "Summer Bank Holiday",
     "1956-12-25": "Christmas Day",
@@ -65,7 +65,7 @@
     "1960-12-26": "Christmas Day (observed)",
     "1961-01-01": "New Year's Day",
     "1961-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1961-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1961-01-03": "New Year Holiday (observed)",
     "1961-03-31": "Good Friday",
     "1961-08-07": "Summer Bank Holiday",
     "1961-12-25": "Christmas Day",
@@ -101,7 +101,7 @@
     "1966-12-26": "Christmas Day (observed)",
     "1967-01-01": "New Year's Day",
     "1967-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1967-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1967-01-03": "New Year Holiday (observed)",
     "1967-03-24": "Good Friday",
     "1967-08-07": "Summer Bank Holiday",
     "1967-12-25": "Christmas Day",
@@ -178,7 +178,7 @@
     "1977-12-27": "Christmas Day (observed)",
     "1978-01-01": "New Year's Day",
     "1978-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1978-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1978-01-03": "New Year Holiday (observed)",
     "1978-03-24": "Good Friday",
     "1978-05-01": "May Day",
     "1978-05-29": "Spring Bank Holiday",
@@ -235,7 +235,7 @@
     "1983-12-27": "Christmas Day (observed)",
     "1984-01-01": "New Year's Day",
     "1984-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1984-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1984-01-03": "New Year Holiday (observed)",
     "1984-04-20": "Good Friday",
     "1984-05-07": "May Day",
     "1984-05-28": "Spring Bank Holiday",
@@ -279,7 +279,7 @@
     "1988-12-27": "Christmas Day (observed)",
     "1989-01-01": "New Year's Day",
     "1989-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1989-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1989-01-03": "New Year Holiday (observed)",
     "1989-03-24": "Good Friday",
     "1989-05-01": "May Day",
     "1989-05-29": "Spring Bank Holiday",
@@ -335,7 +335,7 @@
     "1994-12-27": "Christmas Day (observed)",
     "1995-01-01": "New Year's Day",
     "1995-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1995-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1995-01-03": "New Year Holiday (observed)",
     "1995-04-14": "Good Friday",
     "1995-05-08": "May Day",
     "1995-05-29": "Spring Bank Holiday",
@@ -437,7 +437,7 @@
     "2005-12-27": "Christmas Day (observed)",
     "2006-01-01": "New Year's Day",
     "2006-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2006-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2006-01-03": "New Year Holiday (observed)",
     "2006-04-14": "Good Friday",
     "2006-05-01": "May Day",
     "2006-05-29": "Spring Bank Holiday",
@@ -501,7 +501,7 @@
     "2011-12-27": "Christmas Day (observed)",
     "2012-01-01": "New Year's Day",
     "2012-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2012-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2012-01-03": "New Year Holiday (observed)",
     "2012-04-06": "Good Friday",
     "2012-05-07": "May Day",
     "2012-06-04": "Spring Bank Holiday",
@@ -553,7 +553,7 @@
     "2016-12-27": "Christmas Day (observed)",
     "2017-01-01": "New Year's Day",
     "2017-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2017-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2017-01-03": "New Year Holiday (observed)",
     "2017-04-14": "Good Friday",
     "2017-05-01": "May Day",
     "2017-05-29": "Spring Bank Holiday",
@@ -618,7 +618,7 @@
     "2022-12-27": "Christmas Day (observed)",
     "2023-01-01": "New Year's Day",
     "2023-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2023-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2023-01-03": "New Year Holiday (observed)",
     "2023-04-07": "Good Friday",
     "2023-05-01": "May Day",
     "2023-05-08": "Coronation of Charles III",
@@ -734,7 +734,7 @@
     "2033-12-27": "Christmas Day (observed)",
     "2034-01-01": "New Year's Day",
     "2034-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2034-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2034-01-03": "New Year Holiday (observed)",
     "2034-04-07": "Good Friday",
     "2034-05-01": "May Day",
     "2034-05-29": "Spring Bank Holiday",
@@ -797,7 +797,7 @@
     "2039-12-27": "Christmas Day (observed)",
     "2040-01-01": "New Year's Day",
     "2040-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2040-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2040-01-03": "New Year Holiday (observed)",
     "2040-03-30": "Good Friday",
     "2040-05-07": "May Day",
     "2040-05-28": "Spring Bank Holiday",
@@ -848,7 +848,7 @@
     "2044-12-27": "Christmas Day (observed)",
     "2045-01-01": "New Year's Day",
     "2045-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2045-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2045-01-03": "New Year Holiday (observed)",
     "2045-04-07": "Good Friday",
     "2045-05-01": "May Day",
     "2045-05-29": "Spring Bank Holiday",

diff --git a/snapshots/countries/UK_SCT.json b/snapshots/countries/UK_SCT.json
@@ -1,7 +1,7 @@
 {
     "1950-01-01": "New Year's Day",
     "1950-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1950-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1950-01-03": "New Year Holiday (observed)",
     "1950-04-07": "Good Friday",
     "1950-08-07": "Summer Bank Holiday",
     "1950-12-25": "Christmas Day",
@@ -37,7 +37,7 @@
     "1955-12-26": "Christmas Day (observed)",
     "1956-01-01": "New Year's Day",
     "1956-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1956-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1956-01-03": "New Year Holiday (observed)",
     "1956-03-30": "Good Friday",
     "1956-08-06": "Summer Bank Holiday",
     "1956-12-25": "Christmas Day",
@@ -65,7 +65,7 @@
     "1960-12-26": "Christmas Day (observed)",
     "1961-01-01": "New Year's Day",
     "1961-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1961-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1961-01-03": "New Year Holiday (observed)",
     "1961-03-31": "Good Friday",
     "1961-08-07": "Summer Bank Holiday",
     "1961-12-25": "Christmas Day",
@@ -101,7 +101,7 @@
     "1966-12-26": "Christmas Day (observed)",
     "1967-01-01": "New Year's Day",
     "1967-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1967-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1967-01-03": "New Year Holiday (observed)",
     "1967-03-24": "Good Friday",
     "1967-08-07": "Summer Bank Holiday",
     "1967-12-25": "Christmas Day",
@@ -178,7 +178,7 @@
     "1977-12-27": "Christmas Day (observed)",
     "1978-01-01": "New Year's Day",
     "1978-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1978-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1978-01-03": "New Year Holiday (observed)",
     "1978-03-24": "Good Friday",
     "1978-05-01": "May Day",
     "1978-05-29": "Spring Bank Holiday",
@@ -235,7 +235,7 @@
     "1983-12-27": "Christmas Day (observed)",
     "1984-01-01": "New Year's Day",
     "1984-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1984-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1984-01-03": "New Year Holiday (observed)",
     "1984-04-20": "Good Friday",
     "1984-05-07": "May Day",
     "1984-05-28": "Spring Bank Holiday",
@@ -279,7 +279,7 @@
     "1988-12-27": "Christmas Day (observed)",
     "1989-01-01": "New Year's Day",
     "1989-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1989-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1989-01-03": "New Year Holiday (observed)",
     "1989-03-24": "Good Friday",
     "1989-05-01": "May Day",
     "1989-05-29": "Spring Bank Holiday",
@@ -335,7 +335,7 @@
     "1994-12-27": "Christmas Day (observed)",
     "1995-01-01": "New Year's Day",
     "1995-01-02": "New Year Holiday; New Year's Day (observed)",
-    "1995-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "1995-01-03": "New Year Holiday (observed)",
     "1995-04-14": "Good Friday",
     "1995-05-08": "May Day",
     "1995-05-29": "Spring Bank Holiday",
@@ -437,7 +437,7 @@
     "2005-12-27": "Christmas Day (observed)",
     "2006-01-01": "New Year's Day",
     "2006-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2006-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2006-01-03": "New Year Holiday (observed)",
     "2006-04-14": "Good Friday",
     "2006-05-01": "May Day",
     "2006-05-29": "Spring Bank Holiday",
@@ -501,7 +501,7 @@
     "2011-12-27": "Christmas Day (observed)",
     "2012-01-01": "New Year's Day",
     "2012-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2012-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2012-01-03": "New Year Holiday (observed)",
     "2012-04-06": "Good Friday",
     "2012-05-07": "May Day",
     "2012-06-04": "Spring Bank Holiday",
@@ -553,7 +553,7 @@
     "2016-12-27": "Christmas Day (observed)",
     "2017-01-01": "New Year's Day",
     "2017-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2017-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2017-01-03": "New Year Holiday (observed)",
     "2017-04-14": "Good Friday",
     "2017-05-01": "May Day",
     "2017-05-29": "Spring Bank Holiday",
@@ -618,7 +618,7 @@
     "2022-12-27": "Christmas Day (observed)",
     "2023-01-01": "New Year's Day",
     "2023-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2023-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2023-01-03": "New Year Holiday (observed)",
     "2023-04-07": "Good Friday",
     "2023-05-01": "May Day",
     "2023-05-08": "Coronation of Charles III",
@@ -734,7 +734,7 @@
     "2033-12-27": "Christmas Day (observed)",
     "2034-01-01": "New Year's Day",
     "2034-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2034-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2034-01-03": "New Year Holiday (observed)",
     "2034-04-07": "Good Friday",
     "2034-05-01": "May Day",
     "2034-05-29": "Spring Bank Holiday",
@@ -797,7 +797,7 @@
     "2039-12-27": "Christmas Day (observed)",
     "2040-01-01": "New Year's Day",
     "2040-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2040-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2040-01-03": "New Year Holiday (observed)",
     "2040-03-30": "Good Friday",
     "2040-05-07": "May Day",
     "2040-05-28": "Spring Bank Holiday",
@@ -848,7 +848,7 @@
     "2044-12-27": "Christmas Day (observed)",
     "2045-01-01": "New Year's Day",
     "2045-01-02": "New Year Holiday; New Year's Day (observed)",
-    "2045-01-03": "New Year Holiday (observed); New Year's Day (observed) (observed)",
+    "2045-01-03": "New Year Holiday (observed)",
     "2045-04-07": "Good Friday",
     "2045-05-01": "May Day",
     "2045-05-29": "Spring Bank Holiday",