Update test coverage to 100% (#1573)

vacanza · Nov 26, 2023 · ff1b55c · ff1b55c
1 parent ab99595
commit ff1b55c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/holidays/countries/china.py b/holidays/countries/china.py
@@ -145,7 +145,7 @@ def _add_observed_one_off_holidays(self, dt: date):
                     # 2 Extra Days for May Day >= 2020:
                     self._add_holiday(self[dt], dt + td(days=+3))
                     self._add_holiday(self[dt], dt + td(days=+4))
-            elif 2012 <= self._year <= 2019:
+            else:
                 # [FRI]-SUN
                 self._add_holiday(self[dt], dt + td(days=-1))
                 self._add_holiday(self[dt], dt + td(days=+1))
@@ -154,7 +154,7 @@ def _add_observed_one_off_holidays(self, dt: date):
                 # MON-TUE
                 self._add_holiday(self[dt], dt + td(days=+1))
                 self._add_holiday(self[dt], dt + td(days=+2))
-            elif 2008 <= self._year <= 2011 or self._year >= 2020:
+            else:
                 # [SAT]-MON
                 self._add_holiday(self[dt], dt + td(days=-1))
                 self._add_holiday(self[dt], dt + td(days=+1))

diff --git a/tests/countries/test_china.py b/tests/countries/test_china.py
@@ -286,6 +286,22 @@ def test_2007_public_holiday(self):
             ("2007-12-31", "元旦"),
         )
 
+        self.assertNonObservedHolidays(
+            China(categories=PUBLIC, observed=False, years=2007),
+            ("2007-01-01", "元旦"),
+            ("2007-02-18", "春节"),
+            ("2007-02-19", "春节"),
+            ("2007-02-20", "春节"),
+            ("2007-05-01", "劳动节"),
+            ("2007-05-02", "劳动节"),
+            ("2007-05-03", "劳动节"),
+            ("2007-10-01", "国庆节"),
+            ("2007-10-02", "国庆节"),
+            ("2007-10-03", "国庆节"),
+            ("2007-12-30", "元旦"),
+            ("2007-12-31", "元旦"),
+        )
+
     def test_2008_public_holiday(self):
         # https://www.gov.cn/gongbao/content/2008/content_859870.htm
         self.assertHolidays(