Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timor-Leste holidays #1286

Closed
arkid15r opened this issue Jun 6, 2023 · 3 comments · Fixed by #1516
Closed

Add Timor-Leste holidays #1286

arkid15r opened this issue Jun 6, 2023 · 3 comments · Fixed by #1516
Assignees

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Jun 6, 2023

Links:

@PPsyrius
Copy link
Contributor

I'm working on this atm, also found the exact law wording for East Timor here: https://www.ilo.org/dyn/natlex/docs/ELECTRONIC/79910/86128/F-358739794/TMP79910.pdf

@PPsyrius
Copy link
Contributor

@arkid15r @KJhellico Hi, I got some quick questions here before I create a PR on this after wrapping the translation for this one, should Timor-Leste appear in the holiday registry as holidays.countries.timorleste or holidays.countries.timor_leste ?

The official country name always includes the hyphen (Timor-Leste) i.e. as seen here, pretty sure it's the same case for Guinea-Bissau (#1195) too, but the python interpreter seems to not take this well:

E     File "[directory name]\python-holidays\holidays\countries\__init__.py", line 134
E       from .timor-leste import TimorLeste, TL, TLS
E                  ^
E   SyntaxError: invalid syntax

Please let me know if you have reached a consensus on this.

@arkid15r
Copy link
Collaborator Author

He @PPsyrius,
yeah, you can't do that in Python.

I'd go with holidays.countries.timor_leste for the module name and TimorLeste for the class name based on your description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants