-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timor-Leste holidays #1516
Add Timor-Leste holidays #1516
Conversation
I swear I keep having new PRs created just when we're due for a new release lol
Pull Request Test Coverage Report for Build 6536706928
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
I have just a couple of minor suggestions here:
Co-Authored-By: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇹🇱 LGTM
Proposed change
Add Timor-Leste holidays (
en_US
,pt_TL
,tet
localization;GOVERNMENT
,PUBLIC
,WORKDAY
category) from 2006 onwards, with exact Islamic holiday dates from 2011-2023.Closes #1286.
Note
The only unimplementable holiday instances being the "Day off: Timor Tour" in 2011, which requires per subdiv special holidays support (#1459). This would probably best be its own separate PR in the future once that function is implemented.
Type of change
Checklist
make pre-commit
command generates no changesmake test
,make tox
(we strongly encourage adding tests to your code)