Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add El Salvador holidays #1198

Merged
merged 1 commit into from
May 22, 2023
Merged

Add El Salvador holidays #1198

merged 1 commit into from
May 22, 2023

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Add El Salvador holidays (close #1177).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@KJhellico KJhellico requested a review from arkid15r May 16, 2023 17:08
@KJhellico KJhellico linked an issue May 16, 2023 that may be closed by this pull request
Add El Salvador holidays #1177
Closed
@KJhellico KJhellico mentioned this pull request May 16, 2023
Open
@coveralls
Copy link

Coverage Status

Coverage: 99.738% (+0.0009%) from 99.737% when pulling fe8de9d on KJhellico:add-el-salvador into c548af9 on dr-prodigy:beta.

arkid15r
arkid15r reviewed May 18, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇸🇻 LGTM

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label May 18, 2023
@arkid15r arkid15r merged commit 16007da into vacanza:beta May 22, 2023
22 checks passed
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label May 22, 2023
@KJhellico KJhellico deleted the add-el-salvador branch May 22, 2023 16:00
@KJhellico KJhellico mentioned this pull request May 23, 2023
Closed
@KJhellico KJhellico mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add El Salvador holidays
3 participants
@KJhellico @coveralls @arkid15r